Hi Rob, Thank you for review! I agree with all things you mentioned. It will be fixed in the next v2 patchset. On Tue, Apr 26, 2022 at 03:31:05PM -0500, Rob Herring wrote: > On Tue, Apr 19, 2022 at 03:45:58PM +0000, Rokosov Dmitry Dmitrievich wrote: > > Introduce devicetree binding json-schema for MSA311 tri-axial, > > low-g accelerometer driver. > > > > Signed-off-by: Dmitry Rokosov <ddrokosov@xxxxxxxxxxxxxx> > > --- > > .../bindings/iio/accel/memsensing,msa311.yaml | 64 ++++++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 65 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/iio/accel/memsensing,msa311.yaml > > > > diff --git a/Documentation/devicetree/bindings/iio/accel/memsensing,msa311.yaml b/Documentation/devicetree/bindings/iio/accel/memsensing,msa311.yaml > > new file mode 100644 > > index 00000000..3e4660f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/accel/memsensing,msa311.yaml > > @@ -0,0 +1,64 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > + > > +%YAML 1.2 > > +--- > > +$id: "http://devicetree.org/schemas/iio/accel/memsensing,msa311.yaml#"; > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"; > > + > > +title: MEMSensing digital 3-Axis accelerometer > > + > > +maintainers: > > + - Dmitry Rokosov <ddrokosov@xxxxxxxxxxxxxx> > > + > > +description: | > > + MSA311 is a tri-axial, low-g accelerometer with I2C digital output for > > + sensitivity consumer applications. It has dynamical user selectable full > > + scales range of +-2g/+-4g/+-8g/+-16g and allows acceleration measurements > > + with output data rates from 1Hz to 1000Hz. > > + Datasheet can be found at following URL > > + https://cdn-shop.adafruit.com/product-files/5309/MSA311-V1.1-ENG.pdf > > + > > +properties: > > + compatible: > > + const: memsensing,msa311 > > + > > > + "#address-cells": > > + const: 1 > > + > > + "#size-cells": > > + const: 0 > > These apply to 'reg' in a child node, but you don't have child nodes so > drop them. > Ack > > + > > + reg: > > + maxItems: 1 > > + description: I2C registers address > > + > > + interrupts: > > + maxItems: 1 > > + description: optional I2C int pin can be freely mapped to specific func > > + > > + interrupt-names: > > + const: irq > > + > > +required: > > + - compatible > > + - reg > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/gpio/gpio.h> > > + #include <dt-bindings/interrupt-controller/irq.h> > > + i2c0 { > > i2c { > Ack > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + msa311: msa311@62 { > > accelerometer@62 { > Ack > > + compatible = "memsensing,msa311"; > > + reg = <0x62>; > > + interrupt-parent = <&gpio_intc>; > > + interrupts = <29 IRQ_TYPE_LEVEL_HIGH>; > > + interrupt-names = "irq"; > > + status = "okay"; > > + }; > > + }; > > diff --git a/MAINTAINERS b/MAINTAINERS > > index c75be17..4227914 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -12482,6 +12482,7 @@ MEMSENSING MICROSYSTEMS MSA311 ACCELEROMETER DRIVER > > M: Dmitry Rokosov <ddrokosov@xxxxxxxxxxxxxx> > > L: linux-iio@xxxxxxxxxxxxxxx > > S: Maintained > > +F: Documentation/devicetree/bindings/iio/accel/memsensing,msa311.yaml > > F: drivers/iio/accel/msa311.c > > > > MEN A21 WATCHDOG DRIVER > > -- > > 2.9.5 > > -- Thank you, Dmitry
