On 21/04/2022 16:01, Shreeya Patel wrote:
Thank you for your patch. There is something to discuss/improve.
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + i2c {
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + light-sensor@53 {
> + compatible = "liteon,ltrf216a";
You have here unusual indentation - looks like 8 spaces, while the rest
of example is properly indented with 4 spaces. Please use 4 spaces for
entire DTS example.
All rest looks good, so with indentation fixes:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> + reg = <0x53>;
> + vdd-supply = <&vdd_regulator>;
> + interrupt-parent = <&gpio0>;
> + interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
> + };
> + };
Best regards,
Krzysztof
