On Mon, Apr 18, 2022 at 02:26:29PM +0800, Cixi Geng wrote: > Rob Herring <robh@xxxxxxxxxx> 于2022年4月14日周四 03:12写道： > > > > On Thu, Apr 07, 2022 at 04:21:42PM +0800, Cixi Geng wrote: > > > From: Cixi Geng <cixi.geng1@xxxxxxxxxx> > > > > > > sprd,ump9620-adc is one variant of sc27xx series, add ump9620 > > > description and sample in dt-bindings. > > > > > > Signed-off-by: Cixi Geng <cixi.geng1@xxxxxxxxxx> > > > --- > > > .../bindings/iio/adc/sprd,sc2720-adc.yaml | 57 +++++++++++++++++-- > > > 1 file changed, 53 insertions(+), 4 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml b/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml > > > index caa3ee0b4b8c..0d0f317b75c5 100644 > > > --- a/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml > > > +++ b/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml > > > @@ -20,6 +20,7 @@ properties: > > > - sprd,sc2723-adc > > > - sprd,sc2730-adc > > > - sprd,sc2731-adc > > > + - sprd,ump9620-adc > > > > > > reg: > > > maxItems: 1 > > > @@ -34,12 +35,39 @@ properties: > > > maxItems: 1 > > > > > > nvmem-cells: > > > - maxItems: 2 > > > + description: nvmem-cells. > > > > > > nvmem-cell-names: > > > - items: > > > - - const: big_scale_calib > > > - - const: small_scale_calib > > > + description: Names for each nvmem-cells specified. > > > > These descriptions of common properties are redundant. Just use 'true' > > for the property values. > > > > > + > > > +if: > > > + not: > > > + properties: > > > + compatible: > > > + contains: > > > + enum: > > > + - sprd,ump9620-adc > > > > Use 'const' > > Hi Rob Herring： > did you mean I should use "- const: sprd,ump9620-adc"? or change the > enum to const? > but the above two modification methods have failed for me to test > dt-bindings-check. contains: const: sprd,ump9620-adc
