Re: [v4 12/14] iio: imu: add BNO055 serdev driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Il giorno sab 16 apr 2022 alle ore 10:45 Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> ha scritto:
>
> On Fri, Apr 15, 2022 at 7:40 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> > On Fri, 15 Apr 2022 15:00:03 +0200
> > Andrea Merello <andrea.merello@xxxxxxxxx> wrote:
>
> ...
>
> > > +CFLAGS_bno055_ser.o := -I$(src)
> >
> > Via a bit of grepping I can see other instances of this pattern which point out
> > that it's to do with allowing the tracing framework to see trace.h.
> > Perhaps a similar comment here would be good (if nothing else I doubt I'll
> > remember why this magic is here in a few years time!)
>
> Can be done better way, see dwc3 or drivers/base/ trace point implementations.

May you elaborate, please? It appears that both dwc3 and driver/base
use this same trick of tweaking the CFLAGS in the Makefile in order to
fix the header file thing. What I see is different is that they both
use an (almost empty) trace.c file. Is this what you are suggesting?

>
> --
> With Best Regards,
> Andy Shevchenko



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux