On Thu, Apr 14, 2022 at 08:03:59PM +0300, Andy Shevchenko wrote: > On Thu, Apr 14, 2022 at 10:32:38AM -0400, Liam Beguin wrote: > > Hi Andy, > > > > On Wed, Apr 13, 2022 at 10:01:17PM +0300, Andy Shevchenko wrote: > > > Convert the module to be property provider agnostic and allow > > > it to be used on non-OF platforms. > > > > +#include <linux/mod_devicetable.h> > > > > Is this really needed? > > Yes. > This header is missed. I can split its addition to a separate patch. Understood, maybe a separate patch would make it more explicit. Cheers, Liam > > device_get_match_data() is already defined in <linux/property.h> > > It's indirectly related (just like we do when we clean up of.h). Since > the original of.h is missed there is no header replacement, just adding. > > -- > With Best Regards, > Andy Shevchenko > >