Hi Dan,
Thanks for the report. That email is no longer valid as Mihai moved...
That reminds me that I need to send a patch to update MAINTAINERS.
> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Sent: Friday, April 1, 2022 12:06 PM
> To: mihail.chindris@xxxxxxxxxx
> Cc: linux-iio@xxxxxxxxxxxxxxx
> Subject: [bug report] drivers:iio:dac: Add AD3552R driver support
>
> [External]
>
> Hello Mihail Chindris,
>
> The patch 8f2b54824b28: "drivers:iio:dac: Add AD3552R driver support"
> from Dec 13, 2021, leads to the following Smatch static checker
> warning:
>
> drivers/iio/dac/ad3552r.c:812
> ad3552r_configure_custom_gain()
> warn: 'gain_child' is not an error pointer
>
> drivers/iio/dac/ad3552r.c
> 799 static int ad3552r_configure_custom_gain(struct ad3552r_desc
> *dac,
> 800 struct fwnode_handle *child,
> 801 u32 ch)
> 802 {
> 803 struct device *dev = &dac->spi->dev;
> 804 struct fwnode_handle *gain_child;
> 805 u32 val;
> 806 int err;
> 807 u8 addr;
> 808 u16 reg = 0, offset;
> 809
> 810 gain_child = fwnode_get_named_child_node(child,
> 811 "custom-output-range-config");
> --> 812 if (IS_ERR(gain_child)) {
>
> This should probably be a NULL check right? return -EINVAL;?
Yes to both questions...
- Nuno Sá
