On Thu, Mar 24, 2022 at 7:58 AM Jackie Liu <liu.yun@xxxxxxxxx> wrote:
>
> From: Jackie Liu <liuyun01@xxxxxxxxxx>
>
> kernel robot report build fail by randconfig:
>
> [...]
> drivers/iio/adc/da9150-gpadc.c:254:13: error: ‘DA9150_GPADC_CHAN_0x08’ undeclared here (not in a function); did you mean ‘DA9150_GPADC_CHAN_TBAT’?
> 254 | .channel = DA9150_GPADC_CHAN_##_id, \
> | ^~~~~~~~~~~~~~~~~~
> drivers/iio/adc/da9150-gpadc.c:273:2: note: in expansion of macro ‘DA9150_GPADC_CHANNEL’
> 273 | DA9150_GPADC_CHANNEL(_id, _hw_id, _type, \
> | ^~~~~~~~~~~~~~~~~~~~
> drivers/iio/adc/da9150-gpadc.c:281:2: note: in expansion of macro ‘DA9150_GPADC_CHANNEL_PROCESSED’
> 281 | DA9150_GPADC_CHANNEL_PROCESSED(GPIOD, GPIOD_6V, IIO_VOLTAGE, NULL),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> make[4]: *** [../scripts/Makefile.build:288: drivers/iio/adc/da9150-gpadc.o] Error 1
> make[3]: *** [../scripts/Makefile.build:550: drivers/iio/adc] Error 2
> make[3]: *** Waiting for unfinished jobs....
> [...]
These lines are noise and no need to be in the commit message.
> +/*
> + * Workaround for arch/mips/include/asm/mach-rc32434/rb.h
> + * #define GPIOD 0x08
> + */
> +#undef GPIOD
Looking at the bottom here the better approach seems to be namespacing
of GPIO registers in the above mentioned header and corresponding
users.
> /* Supported channels */
> static const struct iio_chan_spec da9150_gpadc_channels[] = {
> DA9150_GPADC_CHANNEL_PROCESSED(GPIOA, GPIOA_6V, IIO_VOLTAGE, NULL),
--
With Best Regards,
Andy Shevchenko
