Jonathan Cameron <jic23@xxxxxxxxxx> 于2022年3月20日周日 21:22写道： > > On Sat, 12 Mar 2022 00:46:22 +0800 > Cixi Geng <gengcixi@xxxxxxxxx> wrote: > > > From: Cixi Geng <cixi.geng1@xxxxxxxxxx> > > In title, use dt-binding instead of dtbindings at the end. > > > > > sprd,ump9620-adc is one variant of sc27xx series, add ump9620 in > > dtbindings. > > dt-bindings. > > > > > Signed-off-by: Chunyan Zhang <zhang.lyra@xxxxxxxxx> > > Signed-off-by: Cixi Geng <cixi.geng1@xxxxxxxxxx> > > If the patch was authored by Chunyan Zhang, it should be From: Chunyan Zhang, > if it is more complex than you simply passing the patch on then we should > see a co-developed to indicate that. Thanks your advise, I will fix the comment and add correct Signed message > > Patch looks good to me > > Jonathan > > > --- > > .../bindings/iio/adc/sprd,sc2720-adc.yaml | 30 +++++++++++++++++-- > > 1 file changed, 27 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml b/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml > > index caa3ee0b4b8c..331b08fb1761 100644 > > --- a/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml > > +++ b/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml > > @@ -20,6 +20,7 @@ properties: > > - sprd,sc2723-adc > > - sprd,sc2730-adc > > - sprd,sc2731-adc > > + - sprd,ump9620-adc > > > > reg: > > maxItems: 1 > > @@ -37,9 +38,32 @@ properties: > > maxItems: 2 > > > > nvmem-cell-names: > > - items: > > - - const: big_scale_calib > > - - const: small_scale_calib > > + description: Names for each nvmem-cells specified. > > + > > +if: > > + not: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - sprd,ump9620-adc > > +then: > > + properties: > > + nvmem-cell-names: > > + items: > > + - const: big_scale_calib > > + - const: small_scale_calib > > + > > +else: > > + properties: > > + nvmem-cell-names: > > + items: > > + - const: big_scale_calib1 > > + - const: big_scale_calib2 > > + - const: small_scale_calib1 > > + - const: small_scale_calib2 > > + - const: vbat_det_cal1 > > + - const: vbat_det_cal2 > > > > required: > > - compatible >
