Re: [PATCH v3 10/10] iio: adc: ti-ads1015: Switch to read_avail

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/22/22 22:39, Marek Vasut wrote:
On 3/22/22 22:15, Jonathan Cameron wrote:

[...]

diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c
index 66431d1445d9b..b1257f65d7431 100644
--- a/drivers/iio/adc/ti-ads1015.c
+++ b/drivers/iio/adc/ti-ads1015.c
@@ -81,6 +81,9 @@ struct ads1015_chip_data {
      int                num_channels;
      const struct iio_info        *info;
      const unsigned int        *data_rate;
Should probably change this to signed.

The data_rate values are unsigned ... why ?

+    const unsigned int        data_rate_len;
+    const unsigned int        *scale;

Why unsigned int given we use it as an array of signed ints?

Scale is also unsigned ... why ?

Nevermind, I turned all the ranges into unsigned int and sent V4.



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux