On Tue, Mar 22, 2022 at 12:21 AM Jagath Jog J <jagathjog1996@xxxxxxxxx> wrote: > On Mon, Mar 21, 2022 at 10:39:22AM +0200, Andy Shevchenko wrote: > > On Sat, Mar 19, 2022 at 8:10 PM Jagath Jog J <jagathjog1996@xxxxxxxxx> wrote: First of all, you left many uncommented comments. I assume you agree with my comments and are going to address them. If it's not the case, please elaborate. ... > > > +out: > > Just to skip the below "if()" if error occurs in previous regmap read, > I used this label. > if (status & BMA400_INT_DRDY_MSK) > iio_trigger_poll_chained(data->trig); > > I will remove the label in next patch Just return directly. ... > > A useless label. Moreover this raises a question: why is it okay to > > always mark IRQ as handled? > > > > > + return IRQ_HANDLED; > > Since I was not using top-half of the interrupt so I marked IRQ as handled > even for error case in the handler. Yes, but why? Isn't it an erroneous state? Does it mean spurious interrupt? Does it mean interrupt is unserviced? -- With Best Regards, Andy Shevchenko
