On Mon, Mar 21, 2022 at 1:28 AM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > On Sun, Mar 20, 2022 at 8:44 AM Tong Zhang <ztong0001@xxxxxxxxx> wrote: > > > > Regulator should be disabled in error path as mentioned in _regulator_put(). > > Also disable accel if gyro cannot be enabled. > > > > [ 16.233604] WARNING: CPU: 0 PID: 2177 at drivers/regulator/core.c:2257 _regulator_put > > [ 16.240453] Call Trace: > > [ 16.240572] <TASK> > > [ 16.240676] regulator_put+0x26/0x40 > > [ 16.240853] regulator_bulk_free+0x26/0x50 > > [ 16.241050] release_nodes+0x3f/0x70 > > [ 16.241225] devres_release_group+0x147/0x1c0 > > [ 16.241441] ? bmi160_core_probe+0x175/0x3a0 [bmi160_core] > > Haven't I given you a tag? > > -- > With Best Regards, > Andy Shevchenko Hi Any, Thank you for reviewing the patch. I appreciate it. I thought I would need another tag since this patch is a v2. Sorry for this back and forth. Have a great one. Thanks, - Tong
