在 2022/3/18 16:45, Sa, Nuno 写道:
Hi Wang, Thanks for the patch-----Original Message----- From: Wang ShaoBo <bobo.shaobowang@xxxxxxxxxx> Sent: Friday, March 18, 2022 3:59 AM Cc: cj.chengjian@xxxxxxxxxx; liwei391@xxxxxxxxxx; bobo.shaobowang@xxxxxxxxxx; Miclaus, Antoniu <Antoniu.Miclaus@xxxxxxxxxx>; linux-iio@xxxxxxxxxxxxxxx; linux- kernel@xxxxxxxxxxxxxxx; jic23@xxxxxxxxxx; Jonathan.Cameron@xxxxxxxxxx Subject: [PATCH 1/2] iio:filter:admv8818: Add depends on REGMAP [External] Add "depends on REGMAP" to CONFIG_ADMV8818, because admv8818 driver uses structure/symbols such as 'struct regmap_config' which are defined only when CONFIG_REGMAP is set. Fixes: f34fe888ad05 ("iio:filter:admv8818: add support for ADMV8818") Signed-off-by: Wang ShaoBo <bobo.shaobowang@xxxxxxxxxx> --- drivers/iio/filter/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/filter/Kconfig b/drivers/iio/filter/Kconfig index 3ae35817ad82..4bbf10f8692c 100644 --- a/drivers/iio/filter/Kconfig +++ b/drivers/iio/filter/Kconfig @@ -7,7 +7,7 @@ menu "Filters" config ADMV8818 tristate "Analog Devices ADMV8818 High-Pass and Low-Pass Filter" - depends on SPI && COMMON_CLK && 64BIT + depends on REGMAP && SPI && COMMON_CLK && 64BITI think the best way is to have select REGMAP_SPI. Hence: depends on SPI && COMMON_CLK && 64BIT select REGMAP_SPI This will automatically default CONFIG_REGMAP to y. with your patch, I guess we can still have issues with ' __devm_regmap_init_spi()' - Nuno Sá .
Yes, only set REGMAP but REGMAP_SPI may causing __devm_regmap_init_spi undeined.
-- wangshaobo
