Re: [PATCH 1/2] iio: accel: add support for LIS302DL variant

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jonathan

Thank you very much for your review.

On Mon, Feb 28, 2022 at 10:20:21AM +0000, Jonathan Cameron wrote:
> >  	LIS2HH12,
> >  	ST_ACCEL_MAX,
> 
> Think about what ST_ACCEL_MAX is for...
> 
> You'll want to be above that.

I missed this. Thanks for pointing out. I'll prepare a v2.

> However, more interestingly nothing actually uses this enum, so
> you could post a precursor patch that gets rid of it entirely.

Indeed. I noticed this, but thought it had been added for some reason,
or future use. If you agree that removal makes sense, I'll submit that
too.

Also, I have also learned that I should have sent the patch for the
dt_bindings [1] as 1/2 instead of 2/2 as I did. Sincere apologies.

[1] https://lore.kernel.org/linux-iio/Yhv9M%2FaXptQSKQju@xxxxxxxxxxxxxxxxx/T/#u

Regards
Sicelo



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux