On Fri, 25 Feb 2022 14:01:27 +0100
Nuno Sá <nuno.sa@xxxxxxxxxx> wrote:
> The LTC2688 is a 16 channel, 16 bit, +-15V DAC with an integrated
> precision reference. It is guaranteed monotonic and has built in
> rail-to-rail output buffers that can source or sink up to 20 mA.
>
> Signed-off-by: Nuno Sá <nuno.sa@xxxxxxxxxx>
Just one comment below - not a suggestion to change anything at this
stage though, just something that might come up in future.
...
> +static const char * const ltc2688_dither_phase[] = {
> + "0", "1.5708", "3.14159", "4.71239",
> +};
> +
It if turns out we have in kernel users for this in the long run
we may need to change these over to numeric values, but we
can do that without changing the userspace ABI, so this is fine for
now.
...
Thanks,
Jonathan
