On 22/02/2022 11:38, Antoniu Miclaus wrote: > Add device tree bindings for the ADA4250 driver. > > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx> > --- > changes in v5: > - put dt-bindings patch first in the series > - add spaces after `:` in commit subject > .../bindings/iio/amplifiers/adi,ada4250.yaml | 50 +++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml > > diff --git a/Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml b/Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml > new file mode 100644 > index 000000000000..2d22037496bc > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml > @@ -0,0 +1,50 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/amplifiers/adi,ada4250.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ADA4250 Programmable Gain Instrumentation Amplifier > + > +maintainers: > + - Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx> > + > +description: | > + Precision Low Power, 110kHz, 26uA, Programmable Gain Instrumentation Amplifier. > + > +properties: > + compatible: > + enum: > + - adi,ada4250 > + > + reg: > + maxItems: 1 > + > + avdd-supply: true > + > + adi,refbuf-enable: > + description: > + Enable internal buffer to drive the reference pin. > + type: boolean > + > + spi-max-frequency: true > + > +required: > + - compatible > + - reg > + - avdd-supply > + > +additionalProperties: false > + > +examples: > + - | > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + amplifier@0{ The same as in other patches from Analog. Space before '{'. Please fix it in all other patchsets as well. You submit these days around 3-4 different devices, which is cool and great. But please fix pointed out issue not only here, but for every other driver/binding you work on. With the space added: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx> > + compatible = "adi,ada4250"; > + reg = <0>; > + avdd-supply = <&avdd>; > + }; > + }; > +... Best regards, Krzysztof
