On Sun, 20 Feb 2022 13:16:41 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx> wrote:
> On 15/02/2022 09:12, Antoniu Miclaus wrote:
> > Add device tree bindings for the ADMV1014 Upconverter.
> >
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx>
> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
>
> Your subject seems still wrongly formatted.
> > ---
> > changes in v8:
> > - remove `clock-cells`
> > - rename device node to be more generic
> > - set 'maxItems' for clocks property
> > .../bindings/iio/frequency/adi,admv1014.yaml | 134 ++++++++++++++++++
> > 1 file changed, 134 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/iio/frequency/adi,admv1014.yaml
> >
> > diff --git a/Documentation/d
>
> (...)
>
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + spi {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + converter@0{
>
> Missing space after address... I thought you will correct it while
> changing node name.
Fixed up.
>
>
> > + compatible = "adi,admv1014";
> > + reg = <0>;
> > + spi-max-frequency = <1000000>;
> > + clocks = <&admv1014_lo>;
> > + clock-names = "lo_in";
> > + vcm-supply = <&vcm>;
> > + vcc-if-bb-supply = <&vcc_if_bb>;
> > + vcc-vga-supply = <&vcc_vga>;
> > + vcc-vva-supply = <&vcc_vva>;
> > + vcc-lna-3p3-supply = <&vcc_lna_3p3>;
> > + vcc-lna-1p5-supply = <&vcc_lna_1p5>;
> > + vcc-bg-supply = <&vcc_bg>;
> > + vcc-quad-supply = <&vcc_quad>;
> > + vcc-mixer-supply = <&vcc_mixer>;
> > + adi,quad-se-mode = "diff";
> > + adi,detector-enable;
> > + adi,p1db-compensation-enable;
> > + };
> > + };
> > +...
>
>
> Best regards,
> Krzysztof
