[PATCH] iio: mma8452: Fix 'mma8452_dt_ids' defined but not used compiler warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Commit 90adc57bd55a ("iio: mma8452: Fix probe failing when an
i2c_device_id is used") introduces a new: "'mma8452_dt_ids' defined
but not used" compiler warning.

This is caused by the switch from of_match_device() (which takes a
pointer to this) to device_get_match_data(), combined with the use of
of_match_ptr() when setting of_match_table.

We actually want mma8452_dt_ids to get optmized away when CONFIG_OF is
not set, so mark it as __maybe_unused to silence the warning.

Fixes: 90adc57bd55a ("iio: mma8452: Fix probe failing when an i2c_device_id is used")
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
---
Note the 90adc57bd55a hash is from the jic23/iio.git testing branch, not
sure of it is stable. It is probably best to just squash this into the
original commit.
---
 drivers/iio/accel/mma8452.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
index 590d9431e1bd..1324bd515377 100644
--- a/drivers/iio/accel/mma8452.c
+++ b/drivers/iio/accel/mma8452.c
@@ -1529,7 +1529,7 @@ static int mma8452_reset(struct i2c_client *client)
 	return -ETIMEDOUT;
 }
 
-static const struct of_device_id mma8452_dt_ids[] = {
+static const struct of_device_id __maybe_unused mma8452_dt_ids[] = {
 	{ .compatible = "fsl,mma8451", .data = &mma_chip_info_table[mma8451] },
 	{ .compatible = "fsl,mma8452", .data = &mma_chip_info_table[mma8452] },
 	{ .compatible = "fsl,mma8453", .data = &mma_chip_info_table[mma8453] },
-- 
2.33.1




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux