On Sat, Feb 05, 2022 at 06:44:59PM +0000, Jonathan Cameron wrote:
> On Sat, 5 Feb 2022 19:29:39 +0200
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:
>
> A few comments from me, mostly because I couldn't resist jumping in ;)
> Note this is only some of the things Andy raised....
...
> > > +static int ltc2688_channel_config(struct ltc2688_state *st)
> > > +{
> > > + struct device *dev = &st->spi->dev;
> > > + struct device_node *child;
> > > + u32 reg, clk_input, val, tmp[2];
> > > + int ret, span;
> > > +
> > > + for_each_available_child_of_node(dev->of_node, child) {
> >
> > device_for_each_child_node()
>
> This is the old issue with missing
> device_for_each_available_child_node()
> though can just add a check on whether it's available inside the loop.
Didn't we discuss this with Rob and he told that device_for_each_child_node()
is already for available only?
> > > + struct ltc2688_chan *chan;
> > > +
--
With Best Regards,
Andy Shevchenko
