Re: [PATCH v2 03/12] iio: adc: stm32-dfsdm: Avoid dereferencing ->currentmode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/2/22 3:01 PM, Miquel Raynal wrote:
> This is an internal variable of the core, let's use the
> iio_buffer_enabled() helper which is exported for the following purpose:
> telling if the current mode is a buffered mode, which is precisely what
> this driver looks for.
> 
> Cc: Olivier Moysan <olivier.moysan@xxxxxxxxxxx>
> Cc: Fabrice Gasnier <fabrice.gasnier@xxxxxxxxxxx>
> Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> ---

Hi Miquel,

Thanks for your patch, and your answer in v1.

Please feel free to add my:
Reviewed-by: Fabrice Gasnier <fabrice.gasnier@xxxxxxxxxxx>

Best Regards,
Fabrice

>  drivers/iio/adc/stm32-dfsdm-adc.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
> index 1cfefb3b5e56..a3b8827d3bbf 100644
> --- a/drivers/iio/adc/stm32-dfsdm-adc.c
> +++ b/drivers/iio/adc/stm32-dfsdm-adc.c
> @@ -466,8 +466,7 @@ static int stm32_dfsdm_channels_configure(struct iio_dev *indio_dev,
>  	 * In continuous mode, use fast mode configuration,
>  	 * if it provides a better resolution.
>  	 */
> -	if (adc->nconv == 1 && !trig &&
> -	    (indio_dev->currentmode & INDIO_BUFFER_SOFTWARE)) {
> +	if (adc->nconv == 1 && !trig && iio_buffer_enabled(indio_dev)) {
>  		if (fl->flo[1].res >= fl->flo[0].res) {
>  			fl->fast = 1;
>  			flo = &fl->flo[1];
> @@ -562,7 +561,7 @@ static int stm32_dfsdm_filter_configure(struct iio_dev *indio_dev,
>  		cr1 = DFSDM_CR1_RCH(chan->channel);
>  
>  		/* Continuous conversions triggered by SPI clk in buffer mode */
> -		if (indio_dev->currentmode & INDIO_BUFFER_SOFTWARE)
> +		if (iio_buffer_enabled(indio_dev))
>  			cr1 |= DFSDM_CR1_RCONT(1);
>  
>  		cr1 |= DFSDM_CR1_RSYNC(fl->sync_mode);
> 



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux