Re: [PATCH v2 11/13] iio:accel:fxl8962af: Move exports into IIO_FXL8962AF namespace

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jan 16, 2022 at 06:05:33PM +0000, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> 
> To avoid unnecessary pollution of the global symbol namespace move the
> driver core exports into their own namespace and import that into the two
> bus modules.
> 
> For more info see https://lwn.net/Articles/760045/
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> Cc: Sean Nyekjaer <sean@xxxxxxxxxx>

Looks good :)

Reviewed-by: Sean Nyekjaer <sean@xxxxxxxxxx>

> ---
>  drivers/iio/accel/fxls8962af-core.c | 6 +++---
>  drivers/iio/accel/fxls8962af-i2c.c  | 1 +
>  drivers/iio/accel/fxls8962af-spi.c  | 1 +
>  3 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/accel/fxls8962af-core.c b/drivers/iio/accel/fxls8962af-core.c
> index 32989d91b982..8e763dbf096b 100644
> --- a/drivers/iio/accel/fxls8962af-core.c
> +++ b/drivers/iio/accel/fxls8962af-core.c
> @@ -178,7 +178,7 @@ const struct regmap_config fxls8962af_regmap_conf = {
>  	.val_bits = 8,
>  	.max_register = FXLS8962AF_MAX_REG,
>  };
> -EXPORT_SYMBOL_GPL(fxls8962af_regmap_conf);
> +EXPORT_SYMBOL_NS_GPL(fxls8962af_regmap_conf, IIO_FXLS8962AF);
>  
>  enum {
>  	fxls8962af_idx_x,
> @@ -1232,7 +1232,7 @@ int fxls8962af_core_probe(struct device *dev, struct regmap *regmap, int irq)
>  
>  	return devm_iio_device_register(dev, indio_dev);
>  }
> -EXPORT_SYMBOL_GPL(fxls8962af_core_probe);
> +EXPORT_SYMBOL_NS_GPL(fxls8962af_core_probe, IIO_FXLS8962AF);
>  
>  static int __maybe_unused fxls8962af_runtime_suspend(struct device *dev)
>  {
> @@ -1298,7 +1298,7 @@ const struct dev_pm_ops fxls8962af_pm_ops = {
>  	SET_RUNTIME_PM_OPS(fxls8962af_runtime_suspend,
>  			   fxls8962af_runtime_resume, NULL)
>  };
> -EXPORT_SYMBOL_GPL(fxls8962af_pm_ops);
> +EXPORT_SYMBOL_NS_GPL(fxls8962af_pm_ops, IIO_FXLS8962AF);
>  
>  MODULE_AUTHOR("Sean Nyekjaer <sean@xxxxxxxxxx>");
>  MODULE_DESCRIPTION("NXP FXLS8962AF/FXLS8964AF accelerometer driver");
> diff --git a/drivers/iio/accel/fxls8962af-i2c.c b/drivers/iio/accel/fxls8962af-i2c.c
> index cfb004b20455..7e0ecd3bf0d9 100644
> --- a/drivers/iio/accel/fxls8962af-i2c.c
> +++ b/drivers/iio/accel/fxls8962af-i2c.c
> @@ -55,3 +55,4 @@ module_i2c_driver(fxls8962af_driver);
>  MODULE_AUTHOR("Sean Nyekjaer <sean@xxxxxxxxxx>");
>  MODULE_DESCRIPTION("NXP FXLS8962AF/FXLS8964AF accelerometer i2c driver");
>  MODULE_LICENSE("GPL v2");
> +MODULE_IMPORT_NS(IIO_FXLS8962AF);
> diff --git a/drivers/iio/accel/fxls8962af-spi.c b/drivers/iio/accel/fxls8962af-spi.c
> index 57108d3d480b..0357d54d47cc 100644
> --- a/drivers/iio/accel/fxls8962af-spi.c
> +++ b/drivers/iio/accel/fxls8962af-spi.c
> @@ -55,3 +55,4 @@ module_spi_driver(fxls8962af_driver);
>  MODULE_AUTHOR("Sean Nyekjaer <sean@xxxxxxxxxx>");
>  MODULE_DESCRIPTION("NXP FXLS8962AF/FXLS8964AF accelerometer spi driver");
>  MODULE_LICENSE("GPL v2");
> +MODULE_IMPORT_NS(IIO_FXLS8962AF);
> -- 
> 2.34.1
> 



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux