Re: [PATCH v2 12/17] staging:iio:ad7280a: Reflect optionality of irq in ABI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 18 Dec 2021 17:30:06 -0300
Marcelo Schmitt <marcelo.schmitt1@xxxxxxxxx> wrote:

> Not much confident about the attributes of ad7280_info_no_irq.
> With that seen:
> Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@xxxxxxxxx>
> 
> On 12/05, Jonathan Cameron wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> > 
> > Given the irq is optional, let us remove the interfaces related to
> > events when it is not present.
> > 
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> > ---
>> > +static const struct iio_info ad7280_info_no_irq = {
> > +	.read_event_value = &ad7280a_read_thresh,
> > +	.write_event_value = &ad7280a_write_thresh,  
> Think this should be
> 	.read_raw = ad7280_read_raw,
> 	.write_raw = ad7280_write_raw,
Good spot!  You are of course correct. Not sure how I managed that
particular piece of idiocy.

Thanks,

Jonathan



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux