On Fri, Jan 28, 2022 at 6:21 AM Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx> wrote: > > x86 boards may use ACPI HID "TXNW1010" for the hdc100x device. > > TI told us "The ACPI ID for TI is: https://uefi.org/node/1028 (TXNW), > therefore it would most likely be appropriate to use TXNW1010." So, they basically agree on using it, did I get it right? > So add an ACPI match table for that accordingly. Assuming TI is aware of the ID, Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Signed-off-by: Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx> > --- > v3: > - Add info from vendor > - Drop redundant line and comma. > - Wording change. > > v2: > - Change the ID to follow ACPI Spec > - Add __maybe_unused to avoid compiler warning > > drivers/iio/humidity/hdc100x.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c > index 9e0fce917ce4c..47f8e8ef56d68 100644 > --- a/drivers/iio/humidity/hdc100x.c > +++ b/drivers/iio/humidity/hdc100x.c > @@ -417,10 +417,17 @@ static const struct of_device_id hdc100x_dt_ids[] = { > }; > MODULE_DEVICE_TABLE(of, hdc100x_dt_ids); > > +static const struct acpi_device_id hdc100x_acpi_match[] = { > + { "TXNW1010" }, > + { } > +}; > +MODULE_DEVICE_TABLE(acpi, hdc100x_acpi_match); > + > static struct i2c_driver hdc100x_driver = { > .driver = { > .name = "hdc100x", > .of_match_table = hdc100x_dt_ids, > + .acpi_match_table = hdc100x_acpi_match, > }, > .probe = hdc100x_probe, > .id_table = hdc100x_id, > -- > 2.33.1 > -- With Best Regards, Andy Shevchenko
