On Tue, 18 Jan 2022 13:25:04 -0800
Gwendal Grignou <gwendal@xxxxxxxxxxxx> wrote:
> From: Jongpil Jung <jongpil19.jung@xxxxxxxxxxx>
Hi,
Patch title is not really clear. It suggests this is enabling
a new feature rather than fixing anything. Please rephrase.
>
> Fixes: f75095753 ("iio:proximity:sx9360: Add sx9360 support")
This is part of the tag block so should appear.
>
> To convert SX9360 status register ["REG_STAT"], into a channel
> index, we need to right shift by |stat_offset|, not left shift.
> Also the PROXSTAT bit (3) is for channel 1 (PHM, PHase Measured), not (PHR,
> PHase Reference, channel 0), so the offset is 2 instead of 3.
>
Phase
fixes tag should be here.
> Signed-off-by: Jongpil Jung <jongpil19.jung@xxxxxxxxxxx>
> Signed-off-by: Gwendal Grignou <gwendal@xxxxxxxxxxxx>
Thanks,
Jonathan
> ---
> drivers/iio/proximity/sx9360.c | 2 +-
> drivers/iio/proximity/sx_common.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/proximity/sx9360.c b/drivers/iio/proximity/sx9360.c
> index 6fd6561bb6f5b8..3ebb30c8a4f61d 100644
> --- a/drivers/iio/proximity/sx9360.c
> +++ b/drivers/iio/proximity/sx9360.c
> @@ -775,7 +775,7 @@ static const struct sx_common_chip_info sx9360_chip_info = {
> .reg_reset = SX9360_REG_RESET,
>
> .mask_enable_chan = SX9360_REG_GNRL_CTRL0_PHEN_MASK,
> - .stat_offset = 3,
> + .stat_offset = 2,
> .num_channels = SX9360_NUM_CHANNELS,
> .num_default_regs = ARRAY_SIZE(sx9360_default_regs),
>
> diff --git a/drivers/iio/proximity/sx_common.c b/drivers/iio/proximity/sx_common.c
> index ac8fd5920481cb..a7c07316a0a91e 100644
> --- a/drivers/iio/proximity/sx_common.c
> +++ b/drivers/iio/proximity/sx_common.c
> @@ -87,7 +87,7 @@ static void sx_common_push_events(struct iio_dev *indio_dev)
> return;
> }
>
> - val <<= data->chip_info->stat_offset;
> + val >>= data->chip_info->stat_offset;
>
> /*
> * Only iterate over channels with changes on proximity status that have
