On Mon, Jan 10, 2022 at 02:36:54PM +0900, William Breathitt Gray wrote: > On Sun, Jan 09, 2022 at 10:22:51PM +0100, Uwe Kleine-König wrote: > > On Wed, Jan 05, 2022 at 06:41:37PM +0900, William Breathitt Gray wrote: > > > 104_QUAD_8 depends on X86, but compiles fine on ARCH=arm. This patch > > > adds support for COMPILE_TEST which is useful for compile testing code > > > changes to the driver and Counter subsystem. > > > > > > Suggested-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > > Cc: Syed Nayyar Waris <syednwaris@xxxxxxxxx> > > > Signed-off-by: William Breathitt Gray <vilhelm.gray@xxxxxxxxx> > > > --- > > > drivers/counter/Kconfig | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig > > > index 3dcdb681c4e4..5edd155f1911 100644 > > > --- a/drivers/counter/Kconfig > > > +++ b/drivers/counter/Kconfig > > > @@ -14,7 +14,7 @@ if COUNTER > > > > > > config 104_QUAD_8 > > > tristate "ACCES 104-QUAD-8 driver" > > > - depends on PC104 && X86 > > > + depends on (PC104 && X86) || COMPILE_TEST > > > > The driver uses inb and friends. Without looking I wonder if there is > > something like HAVE_IO or similar this needs to depend on for that? > > > > Best regards > > Uwe > > > > -- > > Pengutronix e.K. | Uwe Kleine-König | > > Industrial Linux Solutions | https://www.pengutronix.de/ | > > If I'm not mistaken, on unsupported architectures include/linux/io.h > will pull in include/asm-generic/io.h which has default implementations > for inb and friends if they are not otherwise defined. It doesn't look > like these default implementations are guarded by a Kconfig setting so > we should be fine in this case. Looks right, thanks for checking Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
