On Thu, Dec 30, 2021 at 07:33:20PM +0000, Jonathan Cameron wrote: > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > In order to avoid unnecessary pollution of the global symbol namespace > move the core mma7455 functions into an mma7455 specific namespace and > import that into the two bus modules. > > For more information see https://lwn.net/Articles/760045/ > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > Cc: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > --- > drivers/iio/accel/mma7455_core.c | 6 +++--- > drivers/iio/accel/mma7455_i2c.c | 1 + > drivers/iio/accel/mma7455_spi.c | 1 + > 3 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/accel/mma7455_core.c b/drivers/iio/accel/mma7455_core.c > index e6739ba74edf..4ece5e83a8ab 100644 > --- a/drivers/iio/accel/mma7455_core.c > +++ b/drivers/iio/accel/mma7455_core.c > @@ -238,7 +238,7 @@ const struct regmap_config mma7455_core_regmap = { > .val_bits = 8, > .max_register = MMA7455_REG_TW, > }; > -EXPORT_SYMBOL_GPL(mma7455_core_regmap); > +EXPORT_SYMBOL_NS_GPL(mma7455_core_regmap, MMA7455); > > int mma7455_core_probe(struct device *dev, struct regmap *regmap, > const char *name) > @@ -293,7 +293,7 @@ int mma7455_core_probe(struct device *dev, struct regmap *regmap, > > return 0; > } > -EXPORT_SYMBOL_GPL(mma7455_core_probe); > +EXPORT_SYMBOL_NS_GPL(mma7455_core_probe, MMA7455); > > void mma7455_core_remove(struct device *dev) > { > @@ -306,7 +306,7 @@ void mma7455_core_remove(struct device *dev) > regmap_write(mma7455->regmap, MMA7455_REG_MCTL, > MMA7455_MCTL_MODE_STANDBY); > } > -EXPORT_SYMBOL_GPL(mma7455_core_remove); > +EXPORT_SYMBOL_NS_GPL(mma7455_core_remove, MMA7455); There is a more subtile way to do this. Up to you to judge which you prefer: #define DEFAULT_SYMBOL_NAMESPACE MMA7455 and then use plain EXPORT_SYMBOL_GPL. This way you automatically switch all export statements in this file. (The #define has to be before #include <linux/export.h>.) > MODULE_AUTHOR("Joachim Eastwood <manabian@xxxxxxxxx>"); > MODULE_DESCRIPTION("Freescale MMA7455L core accelerometer driver"); > diff --git a/drivers/iio/accel/mma7455_i2c.c b/drivers/iio/accel/mma7455_i2c.c > index 8a5256516f9f..b7a3d5da8f87 100644 > --- a/drivers/iio/accel/mma7455_i2c.c > +++ b/drivers/iio/accel/mma7455_i2c.c > @@ -61,3 +61,4 @@ module_i2c_driver(mma7455_i2c_driver); > MODULE_AUTHOR("Joachim Eastwood <manabian@xxxxxxxxx>"); > MODULE_DESCRIPTION("Freescale MMA7455L I2C accelerometer driver"); > MODULE_LICENSE("GPL v2"); > +MODULE_IMPORT_NS(MMA7455); > diff --git a/drivers/iio/accel/mma7455_spi.c b/drivers/iio/accel/mma7455_spi.c > index ecf690692dcc..cc17755a1026 100644 > --- a/drivers/iio/accel/mma7455_spi.c > +++ b/drivers/iio/accel/mma7455_spi.c > @@ -49,3 +49,4 @@ module_spi_driver(mma7455_spi_driver); > MODULE_AUTHOR("Joachim Eastwood <manabian@xxxxxxxxx>"); > MODULE_DESCRIPTION("Freescale MMA7455L SPI accelerometer driver"); > MODULE_LICENSE("GPL v2"); > +MODULE_IMPORT_NS(MMA7455); If you put this into the header near the declaration of the functions exported in this namespace, you only need one instead of two. Anyhow, I think this is much a question of personal taste which to prefer, so understand this mail just as a hint about alternatives, not a request to change. Best regards and happy new year, Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
