On Thu, 16 Dec 2021 19:52:08 +0100
Lars-Peter Clausen <lars@xxxxxxxxxx> wrote:
> sysfs_emit() is preferred over raw s*printf() for sysfs attributes since it
> knows about the sysfs buffer specifics and has some built-in checks for
> size and alignment.
>
> Use sysfs_emit() to format the custom device attributes of the ad9523
> driver.
>
> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
> ---
> drivers/iio/frequency/ad9523.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c
> index bdb0bc3b12dd..a0f92c336fc4 100644
> --- a/drivers/iio/frequency/ad9523.c
> +++ b/drivers/iio/frequency/ad9523.c
> @@ -551,7 +551,7 @@ static ssize_t ad9523_show(struct device *dev,
> mutex_lock(&st->lock);
> ret = ad9523_read(indio_dev, AD9523_READBACK_0);
> if (ret >= 0) {
> - ret = sprintf(buf, "%d\n", !!(ret & (1 <<
> + ret = sysfs_emit(buf, "%d\n", !!(ret & (1 <<
> (u32)this_attr->address)));
Obviously not due to this patch, but that's some horrible line breaking.
I might just tidy that up whilst applying this - or send a follow up to
do it.
> }
> mutex_unlock(&st->lock);
