On Wed, Dec 22, 2021 at 09:50:28PM +0200, Andy Shevchenko wrote: > On Wed, Dec 22, 2021 at 9:42 PM Liam Beguin <liambeguin@xxxxxxxxx> wrote: > > On Wed, Dec 22, 2021 at 08:52:30PM +0200, Andy Shevchenko wrote: > > > On Wed, Dec 22, 2021 at 8:20 PM Liam Beguin <liambeguin@xxxxxxxxx> wrote: > > > > On Wed, Dec 22, 2021 at 12:21:01PM +0200, Andy Shevchenko wrote: > > > > > On Wed, Dec 22, 2021 at 5:46 AM Liam Beguin <liambeguin@xxxxxxxxx> wrote: > > ... > > > > > > Missed types.h and forward declarations like > > ^^^^ (1) > > > > > > struct device; > > > > > > > > Okay. will add linux/types.h > > ^^^^ (2) > > > > What about forward declaration? > > > > I'm not sure I understand what you mean here. > > In (1) I have mentioned header and forward declaration. You agreed in > (2) to add a header. What about forward declaration? Oh, understood, sorry I misread your message. I'll add `struct device;` above `struct rescale;`. Cheers, Liam > -- > With Best Regards, > Andy Shevchenko
