Re: [PATCH v2 08/17] staging:iio:adc:ad7280a: Drop unused timestamp channel.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/05, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> 
> The driver doesn't support buffered mode, so a timestamp channel that
> is entirely hidden from userspace without buffer mode is rather pointless.
> Drop it.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@xxxxxxxxx>

> ---
>  drivers/staging/iio/adc/ad7280a.c | 14 +-------------
>  1 file changed, 1 insertion(+), 13 deletions(-)
> 
> diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
> index 032d6430bebf..58bddd07df0c 100644
> --- a/drivers/staging/iio/adc/ad7280a.c
> +++ b/drivers/staging/iio/adc/ad7280a.c
> @@ -613,16 +613,6 @@ static void ad7280_total_voltage_channel_init(struct iio_chan_spec *chan,
>  	chan->scan_type.storagebits = 32;
>  }
>  
> -static void ad7280_timestamp_channel_init(struct iio_chan_spec *chan, int cnt)
> -{
> -	chan->type = IIO_TIMESTAMP;
> -	chan->channel = -1;
> -	chan->scan_index = cnt;
> -	chan->scan_type.sign = 's';
> -	chan->scan_type.realbits = 64;
> -	chan->scan_type.storagebits = 64;
> -}
> -
>  static void ad7280_init_dev_channels(struct ad7280_state *st, int dev, int *cnt)
>  {
>  	int addr, ch, i;
> @@ -650,7 +640,7 @@ static int ad7280_channel_init(struct ad7280_state *st)
>  {
>  	int dev, cnt = 0;
>  
> -	st->channels = devm_kcalloc(&st->spi->dev, (st->slave_num + 1) * 12 + 2,
> +	st->channels = devm_kcalloc(&st->spi->dev, (st->slave_num + 1) * 12 + 1,
>  				    sizeof(*st->channels), GFP_KERNEL);
>  	if (!st->channels)
>  		return -ENOMEM;
> @@ -659,8 +649,6 @@ static int ad7280_channel_init(struct ad7280_state *st)
>  		ad7280_init_dev_channels(st, dev, &cnt);
>  
>  	ad7280_total_voltage_channel_init(&st->channels[cnt], cnt, dev);
> -	cnt++;
> -	ad7280_timestamp_channel_init(&st->channels[cnt], cnt);
>  
>  	return cnt + 1;
>  }
> -- 
> 2.34.1
> 



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux