On Sat, Dec 18, 2021 at 11:58 AM Gwendal Grignou <gwendal@xxxxxxxxxxxx> wrote: > > Before adding new Semtech sensors, move common logic to all Semtech SAR > sensor in its own file: > - interface with IIO subsystem, > - interrupt management, > - channel access conrol, > - event processing. > > The change adds a bidirectional interface between sx93xx and sx_common. ... > +/* All Semtech SAR sensor have IRQ bit in same order. */ sensors in the same ... > +EXPORT_SYMBOL_GPL(sx_common_events); Here and in other places, can we switch to NS variants of the EXPORT_SYMBOL_GPL()? ... > +/** > + * sx_common_probe() - Common setup for Semtech SAR sensor > + * Here and in all similar cases, remove this redundant blank line. > + * @client: I2C client object > + * @chip_info: Semtech sensor chip information. > + * @regmap_config: Sensor registers map configuration. > + */ ... > +#include <linux/types.h> > +#include <linux/iio/iio.h> > +#include <linux/iio/types.h> > +#include <linux/regulator/consumer.h> Perhaps grouped and ordered? + blank line. > +struct device; > +struct i2c_client; > +struct regmap_config; > +struct sx_common_data; ... > + * @num_channels: Number of channel/phase. channels or phases ... > + * @buffer: Bufffer to store raw samples. Buffer -- With Best Regards, Andy Shevchenko
