Re: [PATCH v2 03/17] staging:iio:adc:ad7280a: rename _read() to _read_reg()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/05, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> 
> This avoids possible confusion with read back of the channel conversions.
> These two types of reads are of difference sizes with resulting differences
> in the data layout of the response from the hardware.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@xxxxxxxxx>

> ---
>  drivers/staging/iio/adc/ad7280a.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
> index d169c8a7b5f1..4d866e5fe43c 100644
> --- a/drivers/staging/iio/adc/ad7280a.c
> +++ b/drivers/staging/iio/adc/ad7280a.c
> @@ -224,8 +224,8 @@ static int ad7280_write(struct ad7280_state *st, unsigned int devaddr,
>  	return spi_write(st->spi, &st->buf[0], 4);
>  }
>  
> -static int ad7280_read(struct ad7280_state *st, unsigned int devaddr,
> -		       unsigned int addr)
> +static int ad7280_read_reg(struct ad7280_state *st, unsigned int devaddr,
> +			   unsigned int addr)
>  {
>  	int ret;
>  	unsigned int tmp;
> @@ -476,8 +476,8 @@ static ssize_t ad7280_show_balance_timer(struct device *dev,
>  	unsigned int msecs;
>  
>  	mutex_lock(&st->lock);
> -	ret = ad7280_read(st, this_attr->address >> 8,
> -			  this_attr->address & 0xFF);
> +	ret = ad7280_read_reg(st, this_attr->address >> 8,
> +			      this_attr->address & 0xFF);
>  	mutex_unlock(&st->lock);
>  
>  	if (ret < 0)
> -- 
> 2.34.1
> 



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux