On 12/05, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
>
> The bit reversal was wrong for bits 1 and 3 of the 5 bits.
> Result is driver failure to probe if you have more than 2 daisy-chained
> devices. Discovered via QEMU based device emulation.
>
> Fixes tag is for when this moved from a macro to a function, but it
> was broken before that.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@xxxxxxxxx>
> Fixes: 065a7c0b1fec ("Staging: iio: adc: ad7280a.c: Fixed Macro argument reuse")
> ---
> drivers/staging/iio/adc/ad7280a.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
> index fef0055b8990..20183b2ea127 100644
> --- a/drivers/staging/iio/adc/ad7280a.c
> +++ b/drivers/staging/iio/adc/ad7280a.c
> @@ -107,9 +107,9 @@
> static unsigned int ad7280a_devaddr(unsigned int addr)
> {
> return ((addr & 0x1) << 4) |
> - ((addr & 0x2) << 3) |
> + ((addr & 0x2) << 2) |
> (addr & 0x4) |
> - ((addr & 0x8) >> 3) |
> + ((addr & 0x8) >> 2) |
> ((addr & 0x10) >> 4);
> }
>
> --
> 2.34.1
>
