On Sun, Nov 28, 2021 at 05:24:33PM +0000, Jonathan Cameron wrote: > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > Hi All, > > In the interests of noise reduction in warnings during build tests of > new code, this series suppresses a bunch of warnings seen with > LLVM=1 W=1. > > Note I am seeing two others I haven't fixed here. One is tied up in > the existing CONFIG_PM* cleanup patch set and will be dealt with as > part of that. The other in tsl2772 looks like it might be a bug that > needs further analysis. If anyone is curious: > > drivers/iio/light/tsl2772.c:576:24: warning: variable 'prox_diode_mask' set but not used [-Wunused-but-set-variable] > int i, ret, num_leds, prox_diode_mask; > > As is common with series like this, some of the drivers are old > and as such I haven't cc'd original authors etc and would appreciate > a sanity check from anyone who has the time. > > Mauro and Arnd are cc'd on a bunch of them because a media patch that > I happened to see had similar fixes + discussion of type to use in the > casting. For some others I've just picked on people who touched > the driver in last year or so. > > Nothing in this series should have any functional affect. > > Jonathan I build tested drivers/iio/ for arm, arm64, s390, and x86_64 allmodconfig and did not see any warnings other than the ones mentioned in the commit message. All the fixes look reasonable for the warnings. Reviewed-by: Nathan Chancellor <nathan@xxxxxxxxxx> > Cc: Arnd Bergmann <arnd@xxxxxxxx> > Cc: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> > Cc: Stephan Gerhold <stephan@xxxxxxxxxxx> > Cc: Jean-Baptiste Maneyrol <jmaneyrol@xxxxxxxxxxxxxx> > Cc: Baptiste Mansuy <bmansuy@xxxxxxxxxxxxxx> > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> > Cc: Jonathan Albrieux <jonathan.albrieux@xxxxxxxxx> > > Jonathan Cameron (12): > iio:accel:bma180: Suppress clang W=1 warning about pointer to enum > conversion. > iio:dc:ina2xx-adc: Suppress clang W=1 warning about pointer to enum > conversion. > iio:adc:rcar: Suppress clang W=1 warning about pointer to enum > conversion. > iio:adc:ti-ads1015: Suppress clang W=1 warning about pointer to enum > conversion. > iio:amplifiers:hmc425a: Suppress clang W=1 warning about pointer to > enum conversion. > iio:dac:mcp4725: Suppress clang W=1 warning about pointer to enum > conversion. > iio:imu:inv_icm42600: Suppress clang W=1 warning about pointer to enum > conversion. > iio:imu:inv_mpu6050: Suppress clang W=1 warning about pointer to enum > conversion. > iio:magn:ak8975: Suppress clang W=1 warning about pointer to enum > conversion. > iio:dummy: Drop set but unused variable len. > iio:accel:bmc150: Mark structure __maybe_unused as only needed with > for pm ops. > iio:accel:kxcjk-1013: Mark struct __maybe_unused to avoid warning. > > drivers/iio/accel/bma180.c | 2 +- > drivers/iio/accel/bmc150-accel-core.c | 2 +- > drivers/iio/accel/kxcjk-1013.c | 2 +- > drivers/iio/adc/ina2xx-adc.c | 2 +- > drivers/iio/adc/rcar-gyroadc.c | 3 +-- > drivers/iio/adc/ti-ads1015.c | 2 +- > drivers/iio/amplifiers/hmc425a.c | 2 +- > drivers/iio/dac/mcp4725.c | 2 +- > drivers/iio/dummy/iio_simple_dummy_buffer.c | 2 -- > drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c | 2 +- > drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c | 2 +- > drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c | 2 +- > drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c | 2 +- > drivers/iio/magnetometer/ak8975.c | 2 +- > 14 files changed, 13 insertions(+), 16 deletions(-) > > -- > 2.34.1 > >
