Hi Andy, Thanks for the review. > -----Original Message----- > From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Sent: Wednesday 17 November 2021 5:09 PM > To: Joe Perches <joe@xxxxxxxxxxx> > Cc: Anand Ashok Dumbre <ANANDASH@xxxxxxxxxx>; Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; > jic23@xxxxxxxxxx; lars@xxxxxxxxxx; linux-iio@xxxxxxxxxxxxxxx; git > <git@xxxxxxxxxx>; Michal Simek <michals@xxxxxxxxxx>; > gregkh@xxxxxxxxxxxxxxxxxxx; rafael@xxxxxxxxxx; linux-acpi@xxxxxxxxxxxxxxx; > heikki.krogerus@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v9 5/5] MAINTAINERS: Add maintainer for xilinx-ams > > On Wed, Nov 17, 2021 at 6:05 PM Joe Perches <joe@xxxxxxxxxxx> wrote: > > On Wed, 2021-11-17 at 17:17 +0200, Andy Shevchenko wrote: > > > On Wed, Nov 17, 2021 at 5:00 PM Anand Ashok Dumbre > <ANANDASH@xxxxxxxxxx> wrote: > > > > > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > > > > Sent: Tuesday 16 November 2021 5:42 PM On Tue, Nov 16, 2021 at > > > > > 03:08:42PM +0000, Anand Ashok Dumbre wrote: > > ... > > > > > > Have you run checkpatch? > > > > > > > > Yes I did. > > > > I don't see any error on this. > > > > > > Hmm... Perhaps it needs an unobvious parameter? > > > Joe, X is definitely after M, any idea why checkpatch hasn't caught this > up? > > > > This is the suggested patch below right? > > Correct. > > > https://lore.kernel.org/lkml/20211116150842.1051-6- > anand.ashok.dumbre@ > > xilinx.com/ > > > > It looks OK to me. > > How come? See below. > > > What do you think checkpatch is supposed to find? > > XILINX AXI ETHERNET DRIVER > M: Radhey Shyam Pandey <radhey.shyam.pandey@xxxxxxxxxx> > S: Maintained > F: drivers/net/ethernet/xilinx/xilinx_axienet* > > --> patch adds XILINX AMS DRIVER here !!! > > XILINX CAN DRIVER > > To me AMS should precede AXI and not the other way around. Agree? Got it! Needs to be alphabetical. > > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -20640,6 +20640,13 @@ M: Radhey Shyam Pandey > <radhey.shyam.pandey@xxxxxxxxxx> > > S: Maintained > > F: drivers/net/ethernet/xilinx/xilinx_axienet* > > > > +XILINX AMS DRIVER > > +M: Anand Ashok Dumbre <anand.ashok.dumbre@xxxxxxxxxx> > > +L: linux-iio@xxxxxxxxxxxxxxx > > +S: Maintained > > +F: Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml > > +F: drivers/iio/adc/xilinx-ams.c > > + > > XILINX CAN DRIVER > > M: Appana Durga Kedareswara rao <appana.durga.rao@xxxxxxxxxx> > > R: Naga Sureshkumar Relli <naga.sureshkumar.relli@xxxxxxxxxx> > > -- > > 2.17.1 > > > > > > > > > -- > With Best Regards, > Andy Shevchenko Thanks, Anand
