On Sun, Oct 24, 2021 at 7:13 PM Lars-Peter Clausen <lars@xxxxxxxxxx> wrote:
> IIO trigger handlers need to return one of the irqreturn_t values.
> Returning an error code is not supported.
>
> The kxsd9 interrupt handler returns an error code if reading the data
> registers fails. In addition when exiting due to an error the trigger
> handler does not call `iio_trigger_notify_done()`. Which when not done
> keeps the triggered disabled forever.
>
> Modify the code so that the function returns a valid irqreturn_t value as
> well as calling `iio_trigger_notify_done()` on all exit paths.
>
> Since we can't return the error code make sure to at least log it as part
> of the error message.
>
> Fixes: 0427a106a98a ("iio: accel: kxsd9: Add triggered buffer handling")
> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
Yours,
Linus Walleij
