Crt Mori <cmo@xxxxxxxxxxx> 于2021年10月21日周四 下午8:39写道: > > Hi Yanteng Si, > Why did you limit yourself to restyling just one function in the whole driver? Sorry, I'll restyle the whole driver next. > > If you decide that we should restyle the driver, then please separate > the words with underscores to provide some more meaningful variable > names because name of variable for calculated Ks coefficient for > Temperature Object is kinda more meaningful than calcedksto without > any split or capitalization. Same goes for Ha_customer and Hb_customer > which are coefficients, capitalized in datasheet (hence retained > capitalization in driver) and we want to maintain some sort of > resemblance to the datasheet. OK, Thanks! > > This patch is introducing a strange mix where coefficients from > datasheet are capitalized, but local variables referencing/expanding > them are not and all in just one function. OK, I see. Thanks! Thanks, Yanteng