On Sat, 4 Sep 2021 00:13:11 +0530
Puranjay Mohan <puranjay12@xxxxxxxxx> wrote:
> Replace if(ret < 0) with if(ret) for consistency.
>
> Signed-off-by: Puranjay Mohan <puranjay12@xxxxxxxxx>
There are several other cases where it would be good to clean this up.
Just cleaning one of them up leaves it inconsistent.
>From a quick look I'm fairly sure all the if (ret < 0) can become if (ret)
with no functional change.
Thanks,
Jonathan
> ---
> drivers/iio/accel/adxl355_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/adxl355_core.c b/drivers/iio/accel/adxl355_core.c
> index c91d2254c..0b9996c17 100644
> --- a/drivers/iio/accel/adxl355_core.c
> +++ b/drivers/iio/accel/adxl355_core.c
> @@ -570,7 +570,7 @@ int adxl355_core_probe(struct device *dev, struct regmap *regmap,
> indio_dev->num_channels = ARRAY_SIZE(adxl355_channels);
>
> ret = adxl355_setup(data);
> - if (ret < 0) {
> + if (ret) {
> dev_err(dev, "ADXL355 setup failed\n");
> return ret;
> }
