On Fri, 20 Aug 2021 14:04:15 +0000
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote:
> Hi Yang,
>
> Thank you for the patch.
>
> > -----Original Message-----
> > From: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> > Sent: 19 August 2021 14:24
> > To: linux-kernel@xxxxxxxxxxxxxxx; linux-iio@xxxxxxxxxxxxxxx
> > Cc: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>; jic23@xxxxxxxxxx
> > Subject: [PATCH -next] iio: adc: add missing clk_disable_unprepare() in rzg2l_adc_pm_runtime_resume()
> >
> > Add clk_disable_unprepare() on error path in rzg2l_adc_pm_runtime_resume().
> >
> > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> > Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> > ---
> > drivers/iio/adc/rzg2l_adc.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> With subject line changed to, iio: adc: rzg2l_adc: add missing clk_disable_unprepare() in rzg2l_adc_pm_runtime_resume()
>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
Patch title updated as suggested and applied to the fixes-togreg branch of iio.git
which will go upstream sometime after rc1.
Thanks,
Jonathan
>
> Cheers,
> Prabhakar
>
> > diff --git a/drivers/iio/adc/rzg2l_adc.c b/drivers/iio/adc/rzg2l_adc.c index
> > 9996d5eef289..c38f43ea624f 100644
> > --- a/drivers/iio/adc/rzg2l_adc.c
> > +++ b/drivers/iio/adc/rzg2l_adc.c
> > @@ -570,8 +570,10 @@ static int __maybe_unused rzg2l_adc_pm_runtime_resume(struct device *dev)
> > return ret;
> >
> > ret = clk_prepare_enable(adc->adclk);
> > - if (ret)
> > + if (ret) {
> > + clk_disable_unprepare(adc->pclk);
> > return ret;
> > + }
> >
> > rzg2l_adc_pwr(adc, true);
> >
> > --
> > 2.25.1
>
