> -----Original Message----- > From: Drew Fustini <drew@xxxxxxxx> > Sent: Thursday, August 12, 2021 8:32 PM > To: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > Cc: Sa, Nuno <Nuno.Sa@xxxxxxxxxx>; Andy Shevchenko > <andy.shevchenko@xxxxxxxxx>; linux-iio <linux-iio@xxxxxxxxxxxxxxx>; > Jonathan Cameron <jic23@xxxxxxxxxx>; Lars-Peter Clausen > <lars@xxxxxxxxxx> > Subject: Re: [PATCH v2 1/1] iio: ltc2983: fix device probe > > [External] > > On Thu, Aug 12, 2021 at 07:19:19PM +0100, Jonathan Cameron wrote: > > On Thu, 12 Aug 2021 06:54:13 +0000 > > "Sa, Nuno" <Nuno.Sa@xxxxxxxxxx> wrote: > > > > > > -----Original Message----- > > > > From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > > > > Sent: Wednesday, August 11, 2021 6:15 PM > > > > To: Sa, Nuno <Nuno.Sa@xxxxxxxxxx> > > > > Cc: linux-iio <linux-iio@xxxxxxxxxxxxxxx>; Jonathan Cameron > > > > <jic23@xxxxxxxxxx>; Lars-Peter Clausen <lars@xxxxxxxxxx>; > Drew > > > > Fustini <drew@xxxxxxxx> > > > > Subject: Re: [PATCH v2 1/1] iio: ltc2983: fix device probe > > > > > > > > [External] > > > > > > > > On Wed, Aug 11, 2021 at 4:32 PM Nuno Sá > <nuno.sa@xxxxxxxxxx> > > > > wrote: > > > > > > > > Thanks for an update, my comments below. > > > > Depending on Jonathan's wishes it may or may not require a v3. > > > > If you address the minor issues I commented on, take mine > > > > Reviewed-by: Andy Shevchenko > <andy.shevchenko@xxxxxxxxx> > > > > > > > > > > Thanks for reviewing... Yeah, I will wait for Jonathan's feedback > before > > > sending a v3. It might be that he can apply your inputs when > applying > > > the patch. > > > > Patch looks sensible. I can make the tweaks whilst applying when I > > happen to be on the right computer. > > > > Having glanced at the datasheet, I wonder if you ever had the > > reset pin wired up (and perhaps decided to drop that > > complexity later)? The driver rather oddly > > include of_gpio.h and has no gpio accesses which makes me > > wonder ;) > > I'm sure Nuno will have something to say but I wanted to mention that If my memory is not playing tricks on me, I'm almost positive that I never used the reset pin when working on this driver so my best bet is that the header is there because of some "stupid" copy paste that I did.... Though I also wondered why I did not added support for the reset pin and possibly vdd regulator... > I > was initially thinking about this. The reset pin is connected to a GPIO > on the Zynq-7000 on the custom board I am using. I added that gpio > line > as an active low gpio hog under the gpio controller node in the DTS and > that worked ok. Though I had wondered whether there would ever > be a > case in which the driver would want to reset the LTC2983. > Yeah, since I have the setup ready I might just add support for the optional reset pin. If given, we force a reset during probe. Then, you can remove the gpio hog... - Nuno Sá
