Hi Andy, David and Jonathan First of all thanks you very much for your code snippets ;) More below. On Tue, Aug 10, 2021 at 03:11:01PM +0300, Andy Shevchenko wrote: > On Tue, Aug 10, 2021 at 3:06 PM Andy Shevchenko > <andy.shevchenko@xxxxxxxxx> wrote: > > On Mon, Aug 9, 2021 at 7:14 PM Len Baker <len.baker@xxxxxxx> wrote: > > > > > Even if we leave the logic as is, this might be better > > > > if (orient[0] == '-') > > str = devm_kstrdup(dev, orient + 1, GFP_KERNEL); > > > else if (orient[0] != '0' || orient[1] != '\0') > > str = devm_kasprintf(dev, GFP_KERNEL, "-%s", orient); > > else > > str = devm_kstrdup(dev, orient, GFP_KERNEL); I think the above snippet is the right one: Is compact and easy to understand. > > Or these two swapped for better reading > > else if (orient[0] == '0' **&& orient[1] == '\0') > str = devm_kstrdup(dev, orient, GFP_KERNEL); > else > str = devm_kasprintf(dev, GFP_KERNEL, "-%s", orient); > > And with a comment added that we negate the result according to the > rules: 1) drop leading '-' (minus); 2) leave 0 as is; add leading '-' > (minus). > > > if (!str) > > return -ENOMEM; Also, I think that it is better to leave the logic as is and don't try to use always the +/- sign. Again thanks to all for the feedback. Regards, Len
