On Mon, Aug 9, 2021 at 1:50 AM Liam Beguin <liambeguin@xxxxxxxxx> wrote:
> On Sun Aug 8, 2021 at 12:36 PM EDT, Jonathan Cameron wrote:
> > On Sat, 7 Aug 2021 21:56:57 -0400
> ret = fwnode_property_read_u32(child, "adi,internal-ref-microvolt", &tmp);
> if (ret == -EINVAL && mode & AD7949_CFG_VAL_REF_EXTERNAL) {
> continue;
> } else if (ret < 0) {
Side note, redundant 'else'
> dev_err(dev, "invalid voltage reference in %pfw\n", child);
> fwnode_handle_put(child);
> return ret;
> }
--
With Best Regards,
Andy Shevchenko
