Trying again, text only this time. Sorry for the trouble. On Fri, Aug 6, 2021 at 6:08 AM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > When CONFIG_CROS_EC_SENSORHUB is set to m, the IIO_CROS_EC_SENSORS_CORE > can't be built-in. > > Fixes: 53067471188c ("iio / platform: cros_ec: Add cros-ec-sensorhub driver") > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=213979 > Reported-by: Jason M. <jason@xxxxxxxxxxxx> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > --- > drivers/iio/common/cros_ec_sensors/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/common/cros_ec_sensors/Kconfig b/drivers/iio/common/cros_ec_sensors/Kconfig > index fefad9572790..b0d67ceaed55 100644 > --- a/drivers/iio/common/cros_ec_sensors/Kconfig > +++ b/drivers/iio/common/cros_ec_sensors/Kconfig > @@ -4,7 +4,8 @@ > # > config IIO_CROS_EC_SENSORS_CORE > tristate "ChromeOS EC Sensors Core" > - depends on SYSFS && CROS_EC_SENSORHUB > + depends on CROS_EC_SENSORHUB=y || (CROS_EC_SENSORHUB=m && m) > + depends on SYSFS This seems wrong. IIO_CROS_EC_SENSORS_CORE should already be limited to m if CROS_EC_SENSORHUB=m. Note that I can not reproduce the problem in the bugzilla entry, neither with mainline nor with v5.13.6. And the configuration file published there looks fine and already has IIO_CROS_EC_SENSORS_CORE=m. Guenter > select IIO_BUFFER > select IIO_TRIGGERED_BUFFER > help > -- > 2.30.2 >