Re: [PATCH v2 2/2] dt-bindings: iio: temperature: add MAXIM max31865 support

[Jonathan Cameron <jic23@xxxxxxxxxx>]

On Sun,  1 Aug 2021 09:13:41 +0530
Navin Sankar Velliangiri <navin@xxxxxxxxxxx> wrote:

> Add DT bindings for MAXIM max31865 RTD sensor.
> 
> Signed-off-by: Navin Sankar Velliangiri <navin@xxxxxxxxxxx>
> 
> Note: Changes in v2:
> 	-> Changed the name RTD to Resistance Temperature Detector
> 	-> renamed maxim,no-of-wires to 3-wire
> 	-> fixed code alignment for the example  
As in previous, move changelog below the ---
One request for more detail inline.

Thanks,

J
> ---
>  .../iio/temperature/maxim,max31865.yaml       | 52 +++++++++++++++++++
>  1 file changed, 52 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/temperature/maxim,max31865.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/temperature/maxim,max31865.yaml b/Documentation/devicetree/bindings/iio/temperature/maxim,max31865.yaml
> new file mode 100644
> index 000000000000..13d288311cc6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/temperature/maxim,max31865.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/temperature/maxim,max31865.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Maxim MAX31865 Resistance Temperature Detector.
> +
> +maintainers:
> +  - Navin Sankar Velliangiri <navin@xxxxxxxxxxx>
> +
> +description: |
> +  https://datasheets.maximintegrated.com/en/ds/MAX31865.pdf
> +
> +properties:
> +  compatible:
> +    const: maxim,max31865
> +
> +  reg:
> +    maxItems: 1
> +
> +  maxim,3-wire:
> +    description:
> +      Setting this property enables 3-wire config. Else
> +      2-wire or 4-wire.

Oddly short wrapping on line.  Keep to 80 chars.
Please add add a little more info here about this.
Right now a reader might think this was some sort of odd spi
bus related control (particularly as there are common 3 and 4
wire versions of SPI)

> +    type: boolean
> +
> +  spi-max-frequency: true
> +  spi-cpha: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - spi-cpha
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    spi {
> +       #address-cells = <1>;
> +       #size-cells = <0>;
> +
> +       temp_sensor@0 {
> +         compatible = "maxim,max31865";
> +         reg = <0>;
> +         spi-max-frequency = <400000>;
> +         spi-cpha;
> +         maxim,3-wire;
> +       };
> +    };
> +...