On Wed, 21 Jul 2021 20:40:30 +0200 Arnd Bergmann <arnd@xxxxxxxxxx> wrote: > On Wed, Jul 21, 2021 at 7:34 PM Andy Shevchenko > <andy.shevchenko@xxxxxxxxx> wrote: > > On Wed, Jul 21, 2021 at 7:12 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote: > > > On Wed, Jul 21, 2021 at 5:52 PM Andy Shevchenko > > > <andy.shevchenko@xxxxxxxxx> wrote: > > > > On Wed, Jul 21, 2021 at 6:13 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote: > > > > ... > > > > > > > config FXLS8962AF > > > > > tristate > > > > > + depends on I2C || !I2C # cannot be built-in for modular I2C > > > > > > > > Can you enlighten me how this will not be a no-op? > > > > > > This part does nothing, it only causes a warning when FXLS8962AF > > > gets selected =y when I2C=m. > > > > This is something new to me. But shouldn't the other chunk guarantee > > that warning won't happen? > > Correct, it works without that, but if that fails after something changes, > this version would provide better diagnostics than the FXLS8962AF > core driver causing a link failure, and I found it documents better > why the other driver needs the dependency. > > Let me know if you prefer me to resend the patch without this hunk. > > Arnd Hi Arnd, I didn't think of this particularly combination when we dealt with last build issue the workaround brought in. I've applied this to the fixes-togreg branch of iio.git as an immediately solution, but longer term we should think about just using a function pointer to allow us to move this into the i2c specific module. If we do that we can drop this complex build logic later. Thanks, Jonathan
