On Thu, 8 Jul 2021 12:54:29 +0300 Antti Keränen <detegr@rbx.email> wrote: > Set reset pin direction to output as the reset pin needs to be an active > low output pin. > > Co-developed-by: Hannu Hartikainen <hannu@xxxxxxx> > Signed-off-by: Hannu Hartikainen <hannu@xxxxxxx> > Signed-off-by: Antti Keränen <detegr@rbx.email> So this sits on the boundary of whether it is a fix or not. Do we want this to go into rc1 + stable? If so a fixes tag would be great. Thanks, Jonathan > --- > Removed unnecessary toggling of the pin as requested by Lars-Peter. I > missed out on the conversation, but I agree this is better. > > drivers/iio/imu/adis.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu/adis.c > index 319b64b2fd88..f8b7837d8b8f 100644 > --- a/drivers/iio/imu/adis.c > +++ b/drivers/iio/imu/adis.c > @@ -415,12 +415,11 @@ int __adis_initial_startup(struct adis *adis) > int ret; > > /* check if the device has rst pin low */ > - gpio = devm_gpiod_get_optional(&adis->spi->dev, "reset", GPIOD_ASIS); > + gpio = devm_gpiod_get_optional(&adis->spi->dev, "reset", GPIOD_OUT_HIGH); > if (IS_ERR(gpio)) > return PTR_ERR(gpio); > > if (gpio) { > - gpiod_set_value_cansleep(gpio, 1); > msleep(10); > /* bring device out of reset */ > gpiod_set_value_cansleep(gpio, 0);