On Mon, 14 Jun 2021 18:31:48 +0200, Stephan Gerhold wrote:
> Bosch accelerometers similar to BMA255 are initially configured to
> emit an active-high interrupt signal. This is currently not re-configured
> in the bmc150-accel driver so the interrupt should most certainly be
> IRQ_TYPE_EDGE_RISING (or potentially IRQ_TYPE_LEVEL_HIGH).
> (Unless there is some kind of inverter installed on the board...)
>
> At the moment the bmc150-accel driver forcefully requests the IRQ
> using IRQF_TRIGGER_RISING, which means that the IRQ type is currently
> ignored in all existing device trees.
>
> Fixes: 6259551 ("iio: accel: bmc150-accel: Add DT bindings")
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Signed-off-by: Stephan Gerhold <stephan@xxxxxxxxxxx>
> ---
> It's probably better to let the bmc150-accel driver rely on the IRQ
> type provided by the device tree in case of inverters or something.
>
> However:
> 1. We need to fix up several broken device trees first (I found
> IRQ_TYPE_LEVEL_LOW in some device trees).
> 2. Similarly, I'm not sure if this might break some ACPI devices
> in case they have the wrong IRQ type listed?
>
> As a first step this patch just fixes the documentation.
> ---
> Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Acked-by: Rob Herring <robh@xxxxxxxxxx>
