On Thu, Jun 24, 2021 at 1:01 PM Nicolas Saenz Julienne
<nsaenzju@xxxxxxxxxx> wrote:
>
> The atlas sensor driver currently registers a threaded IRQ handler whose
> sole responsibility is to trigger an irq_work which will in turn run
> iio_trigger_poll() in IRQ context.
>
> This seems overkill given the fact that there already was a opportunity
an opportunity
> to run iio_trigger_poll() in IRQ context in the top half of the IRQ
> handler. So make use of it, ultimately avoiding a context switch, an
> IPI, and reducing latency.
...
> @@ -474,7 +465,7 @@ static irqreturn_t atlas_interrupt_handler(int irq, void *private)
> struct iio_dev *indio_dev = private;
> struct atlas_data *data = iio_priv(indio_dev);
>
> - irq_work_queue(&data->work);
> + iio_trigger_poll(data->trig);
Have you considered dropping atlas_interrupt_trigger_ops() altogether?
> return IRQ_HANDLED;
...
> if (client->irq > 0) {
> /* interrupt pin toggles on new conversion */
> ret = devm_request_threaded_irq(&client->dev, client->irq,
> - NULL, atlas_interrupt_handler,
> + atlas_interrupt_handler, NULL,
So, you move it from threaded IRQ to be a hard IRQ handler (we have a
separate call for this).
Can you guarantee that handling of those events will be fast enough?
> IRQF_TRIGGER_RISING |
> IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
> "atlas_irq",
--
With Best Regards,
Andy Shevchenko
