On Mon, Jun 14, 2021 at 6:34 PM Stephan Gerhold <stephan@xxxxxxxxxxx> wrote:
> Bosch accelerometers similar to BMA255 are initially configured to
> emit an active-high interrupt signal. This is currently not re-configured
> in the bmc150-accel driver so the interrupt should most certainly be
> IRQ_TYPE_EDGE_RISING (or potentially IRQ_TYPE_LEVEL_HIGH).
> (Unless there is some kind of inverter installed on the board...)
>
> At the moment the bmc150-accel driver forcefully requests the IRQ
> using IRQF_TRIGGER_RISING, which means that the IRQ type is currently
> ignored in all existing device trees.
>
> Fixes: 6259551 ("iio: accel: bmc150-accel: Add DT bindings")
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Signed-off-by: Stephan Gerhold <stephan@xxxxxxxxxxx>
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> However:
> 1. We need to fix up several broken device trees first (I found
> IRQ_TYPE_LEVEL_LOW in some device trees).
Oh this situation... Some are mine I bet (I can fix those,
just poke me with something sharp.)
> 2. Similarly, I'm not sure if this might break some ACPI devices
> in case they have the wrong IRQ type listed?
I never figured this out but Andy and maybe Bastien Nocera
knows more about this.
> As a first step this patch just fixes the documentation.
Fair enough, it makes things better.
Yours,
Linus Walleij
