On Sun, 13 Jun 2021 13:36:16 +0300 Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Fri, Jun 11, 2021 at 2:57 PM Jarkko Nikula > <jarkko.nikula@xxxxxxxxxxxxxxx> wrote: > > > > Use to_pci_dev() helper instead of container_of(d, struct pci_dev, dev); > > ... > > > - struct pci_dev *pdev = container_of(dev, struct pci_dev, dev); > > + struct pci_dev *pdev = to_pci_dev(dev); > > struct intel_qep *qep = pci_get_drvdata(pdev); > > Why not change both lines to dev_get_drvdata()? > > > - struct pci_dev *pdev = container_of(dev, struct pci_dev, dev); > > + struct pci_dev *pdev = to_pci_dev(dev); > > struct intel_qep *qep = pci_get_drvdata(pdev); > > Ditto > Question when doing this is whether it is better to pair pci_get_drvdata with pci_set_drvdata rather than assuming it will always map to dev_get_drvdata(). I personally don't feel too strongly about this either way, but I know others are unhappy with mixing them. Of course, could use dev_set_drvdata() in the first place then it would be less of an issue. Jonathan
