On Fri, Jun 11, 2021 at 8:14 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > 0-day recently started running the include-what-you-use checker with LLVM builds. > After it identified a header we should have dropped in a particular patch, > I decided to experiment with it a little and see if it was useful for tidying > up includes that have gotten rather out of sync with the code over the years. > > Note the tool is something I'd only advocate using to give you hints on what > might want adjusting so each of these was done by hand inspection. > > I've grouped them by manufacturer as otherwise we would have a lot of patches. > Note that the big 'many device / device type' drivers have been done separately > so you won't see them in this series. > > I'm rather hoping this approach may ease getting reviews of these, but we > shall see. If people have time to look at ones I haven't directly cc'd them > on that would be great. There are some drivers touched in here where I don't > know of a current maintainer. Same comment as per staging series. I know that kernel.h provides some crucial everywhere used macros / helpers which are in the TODO list to be split. I would recommend dropping kernel.h from the drivers and see what's missed. These series probably need to be based on splitting out container_of() and ARRAY_SIZE() first. So, no tag from me for now (but I like the idea in general, and thanks for looking into this). -- With Best Regards, Andy Shevchenko
