On Thu, Jun 03, 2021 at 07:06:12PM +0100, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
>
> Since:
> commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of
> unnecessary %h[xudi] and %hh[xudi]")
> use of these format strings has been discouraged.
>
> As there are only a few such instances in IIO, this is part of a
> series clearing them out so they don't get copied into new drivers.
>
> Use the 0x02x form as the length specifier when used with # includes
> the 0x prefix and is very unlikely to be what was intended by the author.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> Cc: Nathan Chancellor <nathan@xxxxxxxxxx>
Reviewed-by: Nathan Chancellor <nathan@xxxxxxxxxx>
> ---
> drivers/iio/light/si1145.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/iio/light/si1145.c b/drivers/iio/light/si1145.c
> index 3fb52402fcc3..e2abad48b9f4 100644
> --- a/drivers/iio/light/si1145.c
> +++ b/drivers/iio/light/si1145.c
> @@ -271,7 +271,7 @@ static int si1145_command(struct si1145_data *data, u8 cmd)
> if ((ret & ~SI1145_RSP_COUNTER_MASK) == 0) {
> if (ret == data->rsp_seq) {
> if (time_after(jiffies, stop_jiffies)) {
> - dev_warn(dev, "timeout on command %#02hhx\n",
> + dev_warn(dev, "timeout on command 0x%02x\n",
> cmd);
> ret = -ETIMEDOUT;
> break;
> @@ -291,12 +291,12 @@ static int si1145_command(struct si1145_data *data, u8 cmd)
> ret = -EIO;
> } else {
> if (ret == SI1145_RSP_INVALID_SETTING) {
> - dev_warn(dev, "INVALID_SETTING error on command %#02hhx\n",
> + dev_warn(dev, "INVALID_SETTING error on command 0x%02x\n",
> cmd);
> ret = -EINVAL;
> } else {
> /* All overflows are treated identically */
> - dev_dbg(dev, "overflow, ret=%d, cmd=%#02hhx\n",
> + dev_dbg(dev, "overflow, ret=%d, cmd=0x%02x\n",
> ret, cmd);
> ret = -EOVERFLOW;
> }
> @@ -1299,10 +1299,10 @@ static int si1145_probe(struct i2c_client *client,
> SI1145_REG_SEQ_ID);
> if (ret < 0)
> return ret;
> - dev_info(&client->dev, "device ID part %#02hhx rev %#02hhx seq %#02hhx\n",
> + dev_info(&client->dev, "device ID part 0x%02x rev 0x%02x seq 0x%02x\n",
> part_id, rev_id, seq_id);
> if (part_id != data->part_info->part) {
> - dev_err(&client->dev, "part ID mismatch got %#02hhx, expected %#02x\n",
> + dev_err(&client->dev, "part ID mismatch got 0x%02x, expected 0x%02x\n",
> part_id, data->part_info->part);
> return -ENODEV;
> }
> --
> 2.31.1
